Use pendingQueryRuns available on the event
#36393
Merged
+11
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
LekoArts
added
topic: core
pieh
pushed a commit
that referenced
this pull request
Nov 17, 2022
…#36342) * update version and fix types * yolo add option * Work around removal of meta.state * Refactor `meta.state` access in `gatsby-source-filesystem` (#36355) Co-authored-by: Lennart <lekoarts@gmail.com> * fix ts-ignore * Upgrade XState to the latest 4.33.3 (#36451) * update to latest xstate * Use `pendingQueryRuns` available on the event (#36393) * Revert "Use `pendingQueryRuns` available on the event (#36393)" This reverts commit 9460dd3. Co-authored-by: tyhopp <hopp.ty.c@gmail.com> Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com> Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
mwfrost
pushed a commit
to mwfrost/gatsby
that referenced
this pull request
Apr 20, 2023
…gatsbyjs#36342) * update version and fix types * yolo add option * Work around removal of meta.state * Refactor `meta.state` access in `gatsby-source-filesystem` (gatsbyjs#36355) Co-authored-by: Lennart <lekoarts@gmail.com> * fix ts-ignore * Upgrade XState to the latest 4.33.3 (gatsbyjs#36451) * update to latest xstate * Use `pendingQueryRuns` available on the event (gatsbyjs#36393) * Revert "Use `pendingQueryRuns` available on the event (gatsbyjs#36393)" This reverts commit 9460dd3. Co-authored-by: tyhopp <hopp.ty.c@gmail.com> Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com> Co-authored-by: Ty Hopp <tyhopp@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this should resolve the issue reported by @pieh here: #36342 (comment)
Note that I have no knowledge about this code, I've just analyzed the shape of the machine, and how it's using this context data and I've concluded that it was mostly used locally by this particular
invoke. It was, sort of, used as an argument for this service, and to achieve that it was first set on the context and later on removed from it (from withinonDone). So since this was "temporary" context data, I've just refactored this to use what was already available on theeventitself and removed the redundant code.